Skip to content

[Fix] Change panel header & update snapshot#5304

Merged
ananzh merged 1 commit intoopensearch-project:mainfrom
willie-hung:issue5145
Oct 17, 2023
Merged

[Fix] Change panel header & update snapshot#5304
ananzh merged 1 commit intoopensearch-project:mainfrom
willie-hung:issue5145

Conversation

@willie-hung
Copy link
Copy Markdown
Contributor

@willie-hung willie-hung commented Oct 16, 2023 •
edited
Loading

Description

In the Discover page ("Open" tab), changed the panel header from "Open search" to "OpenSearch".

Issues Resolved

Screenshot

Before

Screenshot 2023-10-16 at 12 02 31 AM

After

Screenshot 2023-10-16 at 12 00 51 AM

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@willie-hung
Change panel header & update snapshot
ec1c339 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #5304 (ec1c339) into main (60f4c8f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5304   +/-   ##
=======================================
  Coverage   66.77%   66.77%           
=======================================
  Files        3284     3284           
  Lines       63095    63095           
  Branches    10049    10049           
=======================================
  Hits        42134    42134           
  Misses      18488    18488           
  Partials     2473     2473
Flag Coverage Δ
Linux_1 35.26% <ø> (ø)
Linux_2 55.24% <ø> (ø)
Linux_3 43.85% <ø> (ø)
Linux_4 35.36% <ø> (ø)
Windows_1 35.27% <ø> (ø)
Windows_2 55.20% <ø> (ø)
Windows_3 43.85% <ø> (ø)
Windows_4 35.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...plication/components/top_nav/open_search_panel.tsx 40.00% <ø> (ø)

@joshuarrrr joshuarrrr added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Oct 16, 2023
joshuarrrr
joshuarrrr approved these changes Oct 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we can skip a changelog entry for this fix.

@joshuarrrr joshuarrrr mentioned this pull request Oct 16, 2023
Closed
8 tasks
@ananzh ananzh merged commit 286cc38 into opensearch-project:main Oct 17, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 18, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2023
@github-actions
Change panel header & update snapshot (#5304)
755aae2 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
(cherry picked from commit 286cc38)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vvavdiya
vvavdiya reviewed Oct 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@vvavdiya vvavdiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@willie-hung willie-hung deleted the issue5145 branch October 21, 2023 01:08
manasvinibs pushed a commit that referenced this pull request Oct 26, 2023
@github-actions @manasvinibs
Change panel header & update snapshot (#5304)
44bd26e 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
(cherry picked from commit 286cc38)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs pushed a commit that referenced this pull request Oct 27, 2023
@opensearch-trigger-bot @github-actions
Change panel header & update snapshot (#5304) (#5316)
f489da8 
(cherry picked from commit 286cc38)

Signed-off-by: Willie Hung <willie880201044@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ananzh ananzh added discover for discover reinvent backport 2.11 labels Feb 8, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 8, 2024
@github-actions
Change panel header & update snapshot (#5304)
d2234de 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
(cherry picked from commit 286cc38)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 8, 2024
Merged
@kavilla kavilla added v2.12.0 and removed v2.12.0 labels Feb 9, 2024
abbyhu2000 pushed a commit that referenced this pull request Feb 9, 2024
@opensearch-trigger-bot @github-actions
Change panel header & update snapshot (#5304) (#5848)
d573923 
(cherry picked from commit 286cc38)

Signed-off-by: Willie Hung <willie880201044@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ananzh ananzh ananzh approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq

+2 more reviewers

@vvavdiya vvavdiya vvavdiya left review comments

@joshuarrrr joshuarrrr joshuarrrr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.x discover for discover reinvent first-time-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG][Discover] Panel header says Open search

5 participants

@willie-hung @joshuarrrr @vvavdiya @ananzh @kavilla
⚡